When to go
Best time
Morning, Mid-day, Late afternoon
Although summer is really hot, you can visit the light shop in Souq Waqif during any month of the year.
If you want the exterior light to flood inside the souq, try visiting in the morning thru late afternoon, depending on the direction you shoot backlight.
Field tips
Be mindful of locals, as well as tourists, and avoid taking portraits without someone's consent.
I think it's best to have a friend with you so they can stand near the entrance/exit and create a nice silhouette. If you're traveling solo, wait for someone to walk through your frame.
In my photo, you'll notice the subject is backlit, giving a very luminous feel. Take note of the light and use it to your advantage.
The market is not well lit inside, so try bracketing to properly expose the area by taking multiple pictures that are slightly brighter and slightly darker than a normal shot, then blending them during post-processing.
If the colors are not warm enough in person, I suggest playing with the white balance in post-production.
Current weather
Do nearby
You can spend an entire day at Souq Waqif! Immerse yourself in the culture and try the local food at eateries, like Sufrat Omi Lolwa.
I highly recommend buying some souvenirs (especially spices!) to have a memory of your trip to the market.